add eventbus for kafka #228
Conversation
docker-compose.yml
Outdated
| @@ -43,3 +44,16 @@ services: | |||
| - pubsub | |||
| - start | |||
| - "--host-port=0.0.0.0:8793" | |||
|
|
|||
| kafka: | |||
| image: wurstmeister/kafka | |||
There was a problem hiding this comment.
Use the "more official" image from Kafka. I would propose to use https://hub.docker.com/r/confluent/kafka/ and also stick image version it should supposed to work. Test may fail in the future when new version with breaking change is introduced. Same with zookeeper.
|
Cool stuff! Sounds good to publish as a separate repo. I have not been able to move the other implementations out yet. Be sure to still run the acceptance tests from here. Also make a PR here with a link in the readme. |
|
I moved event bus kafka to: https://github.com/Kistler-Group/eh-kafka For Kafka i have problem with timeout because initialization of subscription is too slow. With this patch you can define timeout per test. |
eventbus/acceptance_testing.go
Outdated
| @@ -35,7 +35,7 @@ import ( | |||
| // eventbus.AcceptanceTest(t, bus1, bus2) | |||
| // } | |||
| // | |||
| func AcceptanceTest(t *testing.T, bus1, bus2 eh.EventBus) { | |||
| func AcceptanceTest(t *testing.T, timeout time.Duration, bus1, bus2 eh.EventBus) { | |||
There was a problem hiding this comment.
Done! + added link to kafka
- add link to kafka event bus
|
@maxekman This fails in test that I didn't touch. Could you pls check why? |
|
Great! Yeah, there is unfortunately a test that is unstable. I’ll go ahead and merge. |
Summary
Add event bus for Kafka
How to test
Use steps 1 and 2 from: https://kafka.apache.org/quickstart